DSN: Add cfg.Format method #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this implement |
|
The method could be renamed to |
| // the driver. | ||
| func (cfg *Config) FormatDSN() string { | ||
| var buf bytes.Buffer | ||
|
|
There was a problem hiding this comment.
How about
hasParam := false
addParam := func(key, value string) {
p := "&"
if !hasParam {
p = "?"
hasParam = true
}
buf.WriteString(p + key + "=" + value)
}
//...to clean this up a little?
Or split it up in multiple Writes to reduce allocs - but that shouldn't matter much here.
There was a problem hiding this comment.
The boilerplate code here is minimal and is actually useful as it allows to save a few allocations and writes in some cases.
|
LGTM |
julienschmidt
added a commit
that referenced
this pull request
Feb 3, 2016
DSN: Add cfg.FormatDSN method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition allows users to parse a DSN, modify some values and reformat it.
Also it can be used to conveniently build the DSN by filling the Config struct rather then manually building the DSN string.